Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Check just for files in a PR #471

Merged
merged 7 commits into from
Oct 16, 2022
Merged

Link Check just for files in a PR #471

merged 7 commits into from
Oct 16, 2022

Conversation

spier
Copy link
Member

@spier spier commented Oct 14, 2022

Our current link checker will check all links in the main content files (mostly markdown files).
It will do that whenever a PR runs.

With this approach the check reports broken links in files that were not even touched by the given PR.
This can be confusing for the authors of those PRs.

Therefore I am trying something different:

  • add a new link check that will only check the links in the files modified in a given PR
  • modify our existing link check, to only run on a schedule once per week

@spier spier marked this pull request as ready for review October 15, 2022 11:55
@spier
Copy link
Member Author

spier commented Oct 15, 2022

@yuhattor what do you think about this approach to checking links using GitHub Actions?

@spier spier added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label Oct 15, 2022
@yuhattor
Copy link
Member

It's good to reduce the number of requests. Also, it saves waiting time to get the results:)

@spier spier merged commit 9d2eb86 into main Oct 16, 2022
@spier spier deleted the pr-only-link-check branch October 16, 2022 12:27
@robtuley robtuley mentioned this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants