Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mercado Libre as known instance of the Trusted Committer pattern #505

Conversation

privero-meli
Copy link
Contributor

Add Mercado Libre as known instance of the Trusted Committer pattern

@spier spier added 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. labels Dec 5, 2022
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment inline.

Also would you mind adding the image to folder /assets/img.
Then we can add a relative link to that from the markdown file.

@privero-meli privero-meli requested review from spier and removed request for robtuley, NewMexicoKid, lenucksi and cewilliams December 5, 2022 19:09
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@privero-meli just noticed one more thing:
If I understand it correctly, the image is meant to be a mock of the CONTRIBUTING.md section in use at mercadolibre. Right?

However the text uses the wording "working group", which may be confusing in this context?

Also noticed that the text is pretty close to what we use in the our own TC file in this repo.

So maybe something that went unnoticed when copying the text?

@spier
Copy link
Member

spier commented Dec 5, 2022

Btw not sure what the best wording in the context of an InnerSource repo is.

Here is another example of a TC file that I contributed to. However that one is for an open source project, so again the wording might not be 100% fitting for InnerSource.

@privero-meli
Copy link
Contributor Author

@privero-meli just noticed one more thing: If I understand it correctly, the image is meant to be a mock of the CONTRIBUTING.md section in use at mercadolibre. Right?

However the text uses the wording "working group", which may be confusing in this context?

Also noticed that the text is pretty close to what we use in the our own TC file in this repo.

So maybe something that went unnoticed when copying the text?

In Mercado Libre, to add a repository to Inner Source, the repository must have a CONTRIBUTOR file that includes this section.

Each repository has its owners and a reduced group of those owners are Trusted Committers. This is why we think "working group" makes sense.

And yes, it is clear that the section was taken from your CONTRIBUTING file 😀

Extend hover text for image.
Note that this will only used in GitHub, not in the published gitbook.
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

We could consider to turn the image from Mercado Libre into text (a quote maybe?).
That way others can just copy and paste it, rather than having to re-type it all.
However we can leave that for a future PR, if we like that idea.

Thank you for this great contribution @privero-meli!

@spier spier merged commit 83a9f3e into InnerSourceCommons:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants