-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mercado Libre as known instance of the Trusted Committer pattern #505
Mercado Libre as known instance of the Trusted Committer pattern #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment inline.
Also would you mind adding the image to folder /assets/img
.
Then we can add a relative link to that from the markdown file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@privero-meli just noticed one more thing:
If I understand it correctly, the image is meant to be a mock of the CONTRIBUTING.md
section in use at mercadolibre. Right?
However the text uses the wording "working group", which may be confusing in this context?
Also noticed that the text is pretty close to what we use in the our own TC file in this repo.
So maybe something that went unnoticed when copying the text?
Btw not sure what the best wording in the context of an InnerSource repo is. Here is another example of a TC file that I contributed to. However that one is for an open source project, so again the wording might not be 100% fitting for InnerSource. |
In Mercado Libre, to add a repository to Inner Source, the repository must have a CONTRIBUTOR file that includes this section. Each repository has its owners and a reduced group of those owners are Trusted Committers. This is why we think "working group" makes sense. And yes, it is clear that the section was taken from your CONTRIBUTING file 😀 |
Extend hover text for image. Note that this will only used in GitHub, not in the published gitbook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
We could consider to turn the image from Mercado Libre into text (a quote maybe?).
That way others can just copy and paste it, rather than having to re-type it all.
However we can leave that for a future PR, if we like that idea.
Thank you for this great contribution @privero-meli!
Add Mercado Libre as known instance of the Trusted Committer pattern