-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create assisted_compliance.md #74
Conversation
This is: Helping repo owners be compliant by writing their CONTRIBUTING.md for them as a pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a bit of work to be done ...
assisted_compliance.md
Outdated
## Problem | ||
The team that owns the repository doesn't have a CONTRIBUTING.md; the task force needs them to have this to submit bug fixes. | ||
|
||
## Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way the context is written make me think that the pattern only applies in a very narrow case. I feel we need to abstract a few things to make it more applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest some ways to abstract it? Is the key restrictive context the mandatory nature of the CONTRIBUTING.md file?
assisted_compliance.md
Outdated
* There may be export control compliance and legal compliance requirements; a template is provided to repository owners | ||
|
||
## Forces | ||
* Teams have been resisting this; this ends up wasting time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like context to me
assisted_compliance.md
Outdated
* Rather than asking the resisting team to do the changes, they create the documentation (in addition to negotiations) | ||
* Taking the contributor perspective (contributors are motivated). They are writing the CONTRIBUTING.md documentation for those teams resistant to doing the fixes, doing this as pull requests. The discussion is then documented in the pull request. The resisting development teams then just correct mistakes. | ||
* "Let us help you be compliant" | ||
* You could do an audit to assess the state of compliance. Bots could be used to check compliance; and the state of compliance could show up in an internal portal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to make this less conditional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gruetter, I agree: IMHO, beneficiaries of an automated PR with a CONTRIBUTING.md doc should be viewed as an act of service, not enforcement.
Maybe pitch this as a benefit, e.g.,
Let us help you market your software and convert users into contributors.
As you can see on the InnerSourcePattern repository's "Community profile" page, GitHub considers CONTRIBUTING one of several recommended community standards:
README.md
,CODE_OF_CONDUCT.md
,CONTRIBUTING.md
,LICENSE
,ISSUE_TEMPLATE.md
, andPULL_REQUEST_TEMPLATE.md
Once people realize value of these documents--e.g., "A good README.md file will help people discover your projects from Intranet search," teams start to realize that CONTRIBUTING docs are a benefit instead of a chore.
On the other hand, some people just don't want to participate for one reason or another.
🔌 In anticipation of an formally recognized InnerSource Program at my company, I created
generator-community
, which generates those recommended community standards templates. Oncegenerator-community
reaches MVP, I'll InnerSource a micro-service that detects repos with docs, and then automatically submit a PR with the benefits of those docs explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is ideal to persuade rather than to enforce, the fact that this pattern was written shows that persuasion may not be sufficient. I agree that getting people to understand the benefits should be something tried first (and this should be part of the pattern).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, @NewMexicoKid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregswindle I know that this conversation here is a loooong while back. I just wanted to let you know what we have merged the pattern to the main line by now.
I am also curious to learn more about your project https://github.com/commonality/generator-community and what experiences you made with it. If you would like to chat about it, feel free to reply here or join the community in https://innersourcecommons-inviter.herokuapp.com/ :)
Hi @NewMexicoKid and @gruetter (mentioning you as you both spent quite some time on this PR already). We have reworked the maturity levels of the InnerSource patterns. The new levels make it more explicit what quality standards are expected for each level. With that we will also try to get PRs merged into master faster. Status of this pattern: We have currently categorized the Pattern in this PR as maturity level Level 2 - Structured. For that level we have two requirements:
How to get this PR merged?
I have no time to work on this, what to do? As this PR is open for a while, it would be completely understandable if your priorities have shifted and you don't time to work on this anymore. In that case please just let us know in a comment below. Then we can decide what to do with this PR on our own. Thank you for your help! 👍 |
Thanks @spier for adding this update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added commit suggestion, @lenucksi.
Co-authored-by: rrrutledge <rrrutledge@users.noreply.github.com>
Should we generalize this pattern to include other GitHub Community health files such as |
Interesting question @dellagustin. Thoughts about the patterns: The pattern Standard base documentation seems related. That pattern introduces One approach to make these patterns work well together, while also implementing your idea could be:
Thoughts about the process: Personally I would stay away from adding any further scope to this PR, as it already open since Jun 2017. Instead I would try to finish this PR here, and file new issues and PRs for any additional ideas related to this. That would also allow you to do this new work in parallel, without being blocked by this PR. |
…moving the entry to the right group.
@NewMexicoKid @gruetter I took a lot of liberties in resolving the inline-discussions that the two of you had around this pattern in 2017/18. Most of the time I just worked in whatever the last suggestion from either of the two of you was :) I then marked the pattern as Level 1 (Initial) and moved it to the corresponding folder. I left a couple of conversations open (see above) where I couldn't see a clear resolution path. Quick path to mergeHowever given that this PR is in this state for so long already, I would like to suggest this way forward:
TimerPlease provide 👍 or 👎 on the suggested approach. To get this over the finish line I will put also put a timer on this: |
👍
I’m impressed with the way you handle this, Sebastian. Kudos … and thanks!
> Georg
On 22. January 2021 at 20:05:52, Sebastian Spier (notifications@github.com) wrote:
@NewMexicoKid <https://github.com/NewMexicoKid> @gruetter
<https://github.com/gruetter> I took a lot of liberties in resolving the
inline-discussions that the two of you had around this pattern in 2017/18.
Most of the time I just worked in whatever the last suggestion from either
of the two of you was :)
I then marked the pattern as *Level 1 (Initial)* and moved it to the
corresponding folder.
*Why?* It doesn't have Known Instances yet.
I left a couple of conversations open (see above) where I couldn't see a
clear resolution path.
*Note:* As I moved the file, it is a bit harder to see now which line in
the new file the conversations where about.
Quick path to merge
However given that this PR is in this state for so long already, I would
like to suggest this way forward:
- Simply ignore the open conversations and get the pattern merged as is.
That allows us to share it with the larger Patterns Community (as I doubt
that everybody is reading PRs :))
- If anybody decides to work on this pattern further in the future e.g.
because they have used something like this in their company, then they
would naturally review and improve the pattern again anyways.
- In addition, this is an 1-Initial pattern, so it is fine if isn't
reviewed yet in every last level of detail.
Timer
Please provide 👍 or 👎 on the suggested approach.
To get this over the finish line I will put also put a timer on this:
If there is no objection by next Friday (29th) then I will merge this PR as
is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAV5U6QDLBG4XISYSY54LK3S3HEA7ANCNFSM4DO56ARA>
.
|
Reaching timer. Merging. I added a reference section, pointing to some interesting discussions in this PR. One more draft pattern from the old days (2017) merged into the mainline. 🎉 |
This is: Helping repo owners be compliant by writing their CONTRIBUTING.md for them as a pull request.
It was created/documented at the 2017-06-08 InnerSource Patterns meeting.