Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise PHPStan level to max and allow multiple mailers #23

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Raise PHPStan level to max and allow multiple mailers #23

merged 3 commits into from
Apr 22, 2024

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Apr 2, 2024

MicrosoftGraphApiService is no longer bound to the service container, as there can be multiple instances of it with different mailer configurations.

@spawnia spawnia changed the title Work towards PHPStan level max Raise PHPStan level to max and allow multiple mailers Apr 2, 2024
@spawnia spawnia marked this pull request as ready for review April 2, 2024 12:40
@spawnia
Copy link
Contributor Author

spawnia commented Apr 3, 2024

I just tried this branch in a project, it works fine.

@spawnia spawnia requested a review from geisi April 3, 2024 08:04
@spawnia
Copy link
Contributor Author

spawnia commented Apr 22, 2024

@geisi I am successfully running this branch in production for 3 weeks now and would love to get back to using a stable version of your package. If you can find the time to do another review and potentially include it, that would be great. Thanks for the great package, it has made sending mails much more reliable for us.

@geisi
Copy link
Contributor

geisi commented Apr 22, 2024

@spawnia I will have a look at it soon!

@geisi geisi merged commit 2336ce2 into InnoGE:main Apr 22, 2024
17 checks passed
@spawnia spawnia deleted the phpstan-level-max branch April 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants