[manualRegistration] solve top views size problem #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollot
approved these changes
Nov 2, 2023
fcollot
added a commit
that referenced
this pull request
Apr 11, 2024
* Add PYNCPP external project * [add PYNCPP] Minor changes following review * [Four-views] solve crash closing the views * [Zoom] proper zoom displaying data on xy and not xyz * [Tabs] handling of tabs: removal, switch * [Tabs] manage the case of removing the last tab before opening new ones * [N4Bias] manage process cancel if the user wants to quit the app * [Reslice] fix zoom error + code clarity * [Reslice] dimension -> size * [Paint] create mask before trying to paint + hide a button * [3.3.1] release notes & version number with four view crash-fix * [Git diff] solve differences between musicardio to medInria3.4 * [DCM] do not corrupt exported/imported dcm with odd axis * set minimum cmake version to 19 * [Registration] selector toolbox empty connect * [DCMTKImageIO] redo GetPositionOnStackingAxisForImage to get closest axis * [DCM] get the index value from metadata string * [DCMTKImageIO] debug if max abs value is not first * [CMake] minimum version at 3.19 * [CMake] minimum inside src set with variable * [CMake] remove unnecessary cmake mimum required fct * [med3.4] Release notes and version number * [release notes] add bug fix 3.3.2 * [Github] ssh key change * [MemoryLeak] homepage widgets * Python packaging and initialization (medInria#1123) * adapt to PYNCPP changes * switch to lowercase for pyncpp * Fix handling of install path of embedded Python * more Python fixes * Minor correction to find OpenSSL automatically on macOS * [VTK] avoid med crash with wrong version of vtk files * [Thumbnail]3.4, add a setting to [de]activate thumbnail generation for RAM purpose * [Thumbnail] add final line in file * [SplashScreen] speeds up launch removing txt on splashscreen * make Packaging a dedicated project (medInria#1141) * Packaging project * packaging fix * [Thumbnail] generate thumbnail setting typo, oups * [MemoryLeak] DCMTKImageReader and INRImageReader * [MemoryLeak] enhance dcmtk image reader destructor * [memLeak] rm changes on mutex * [MemoryLeak] medLogger TeeStreams, TeeDevices and d (medInria#1117) * [MemoryLeak] medLogger TeeStreams, TeeDevices and d * [MemoryLeak] medLogger: buffers * [Settings] solve graphical bug of database widget * [MemoryLeak] medVtkView::buildThumbnail (medInria#1124) * [MemoryLeak] medVtkView::buildThumbnail * [MemoryLeak] medAbstractData::generateThumbnailInGuiThread * [MemoryLeak] rm TimeLineParam changes, created segfault closing the app * [MemoryLeaks] solve several memory leaks (medInria#1130) * [MemoryLeak] medAbstractData::generateThumbnailInGuiThread * [MemoryLeak] rm TimeLineParam changes, created segfault closing the app * [RAM] solve some memory leaks * [RAM] mem leak with instances * [MemLeak] rm composer, do not instantiate everything on homepage, etc * [MemLeak] solve a graphic pb in Paint * [vtkImage2DDisplay] vtkSmartPointer instead of Delete * [medParameterPoolManagerL] parameters in std::shared_ptr, private class in unique_ptr * [instances] switch to std::unique_ptr * [viewinteractor] add back a deletion * [medToolBoxHeader] remove unnecessary nullptr after delete * [RAM] after review, remove some QString and changes * [medVtkImageInfo] proper reset of a complex structure (medInria#1151) * [Instances] adapt new singleton system to new code (medInria#1161) * [vtkImageInfo] an other way to reset the complex structure and please gcc (medInria#1162) * [medToolBoxHeader] no need to delete png (medInria#1163) * [medCropToolBox] fix error return value (medInria#1164) * workaround for Inrimage exporting on 3.4 (medInria#1166) * [DCMTKreader] roll back on a change on static Qlist * [SlashScreen] use directly QSplashScreen & update splash medInria logo * [Splash] correction of a square on the logo * [Splash] no need to test here splashScreen variable * [3.4] update release notes with current enhancement (medInria#1169) * [Close] 4D+3D data in view crash at app closing * [Thumbnail] no need to warn if no thumbn since the thumbnail setting added * [Splash] add closing attribute to delete variable * [Histogram] switch QObject+QGraphicsItem to QGraphicsObject * [Thumbnail] remove a warning reading data * [Parameters] solve mem leaks * [Closing] no need to delete manually labels here * [PolygonROI] ROI/repulsor crashs and interactor problems (#807) * [4D data] fix Cropping, Variational Seg and VoiCutter toolboxes (#782) * [4D data] fix Cropping, Variational Seg and VoiCutter toolboxes * [CropTlbx] use proper return value * [ProcessOutputs] adapt methods to processoutputs * [manualRegistration] solve top views size problem (#781) * [polygonRoi] process output returned nullptr (#772) * [polygonRoi] fix processsOutput crash when no roi (#777) * Remove annotation data when destroying paint toolbox (#771) * [Paint] crash at app closing if no painting (#776) * [PolygonRoi] avoid spam of warning if contour outside image (#775) * [PolygonRoi] avoid spam of warning if contour outside image * [PolygonRoi] loop index from 0 * [Reslice] proper release of RAM (#774) * [Reslice] proper release of RAM * [Reslice] copy view data before destruction * [Reslice] in case user drops 2D image in view (we never know...) * [vtkImage2DDisplay] vtkSmartPointer instead of Delete * [Reslice] use std::array and avoid a loop * [ResliceToolBox] use std::array and avoid a loop * [view] put back previous behavior, if needed it'll be changed by medInria * [view] rm deleted variable set to nullptr as in original PR * [merge] prepare rebase * [polygonRoi] hide activation label (#773) * Assume 0 for missing origin * [Paint] solve problems switching between tools (#770) * [Paint] solve problems switching between tools * Update medAlgorithmPaintToolBox.cpp : && instead of && * [Paint] separate condition for add and erase * [Paint] allow to forceHide the Save button (#767) * [Polygon] adapt to change of instance * [PolygonROI] pipeline adaptation - put back extension to include * Compile VTK Python wrappings (with pyncpp's Python) * Add python plugin path (#763) * [instances] merge * allow duplicate series names * [Export] allow export of multiple data at same time (#780) * [Video] put a better default frame rate * [DCM] same test as on med3.3 branch, quicker * [DCMTK] repo not accessible anymore, switch to github * {Reslice} background color for selected view * Switch to <package_name>_ROOT (medInria#1212) * [Linux packaging] install external projects manually (medInria#1216) * Fix python packaging (medInria#1213) * Place superbuild options earlier (medInria#1215) * [PolygonRoi] clear deactivating the tlbx (#812) (medInria#1223) Co-authored-by: mathildemerle <mathilde.merle@ihu-liryc.fr> * [VoiCutter] solve keys, min and max intensity, and add waiting toolbox (#829) (medInria#1222) * {VoiCutter} keySym instead of keyCode and wait status * [VoiCutter] solve min and max intensity and keys on mac & linux Co-authored-by: mathildemerle <mathilde.merle@ihu-liryc.fr> * added a patch for ITK to compile on visual studio 2019 (medInria#1221) * Remove BUILD_ALWAYS from external projects (medInria#1220) * Use DICOM Ids to identify patients and studies (medInria#1219) * Add development settings (medInria#1218) * Order of settings widgets (medInria#1217) * Adapt ep initialization macro for non-cmake projects (medInria#1214) * Minor changes (spaces etc.) (medInria#1226) * Icon in Windows taskbar (medInria#1225) * Avoid removal of files during windows install (medInria#1224) * merge fixes --------- Co-authored-by: MERLE Mathilde <“mathilde.merle@ihu-liryc.fr”> Co-authored-by: MathouNH <mathilde.merle@pm.me> Co-authored-by: Florent <florent.leray@inria.fr> Co-authored-by: Mathilde Merle <mathilde.merle@ihu-liryc.fr> Co-authored-by: paulineMig <pauline.migerditichan@rebrain.eu> Co-authored-by: jcastelneau <julien.castelneau@ihu-liryc.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
constructContainersmethod, used in pipelines for instance had a problem. Its 2 top views were not the same size.