Add work of Thomas Durantel #102
Conversation
- Add a Track Orientation Distribution (TOD) image estimator (Dhollander et al. 2014).
Add some diffusion features developed by Thomas Durantel during his PHD
Anima/diffusion/odf/tod_estimator/animaTODEstimatorImageFilter.h
Outdated
Show resolved
Hide resolved
|
If you check the box to allow edits from maintainers I'll be able to push to the PR branch on your fork to make a few fixes. |
|
I see it is the case now. I will fork and work on it soon. Thanks @Florent2305! |
|
I am done here. Thomas says it works as expected. @Florent2305 do you want to review or should I merge? |
|
We can try to make a release of Anima before his defence now. That implies updating ITK and VTK and the documentation. |
| "ODF images list as a text file", | ||
| true, "", "ODF images list", cmd); | ||
| "i", "input-odf-file", | ||
| "A string specifying the name of a text file in which the ODF images are listed.", |
There was a problem hiding this comment.
A path or file name to specify the text file in which the ODF images are listed.
| "m", "masks", | ||
| "Masks images list as a text file", | ||
| true, "", "Masks images list", cmd); | ||
| "w", "input-weight-file", |
| "Result average ODF", | ||
| true, "", "result ODF image", cmd); | ||
| "o", "output-file", | ||
| "A string specifying the name of the output average ODF image.", |
| maskFiles.push_back(maskStr); | ||
| numInput++; | ||
| weightFiles.push_back(maskStr); | ||
| numInputs++; |
There was a problem hiding this comment.
numInputs = weightFiles.size(); après l'accolade
| std::vector<std::string> maskFiles; | ||
| unsigned int numInput = 0; | ||
| std::vector<std::string> weightFiles; | ||
| unsigned int numInputs = 0; | ||
| while (!odfFile.eof()) | ||
| { | ||
| char tmpStr[2048], maskStr[2048]; | ||
| odfFile.getline(tmpStr, 2048); |
There was a problem hiding this comment.
we need error msg if line is over 2048
|
All fixed. We should be good to go. @Florent2305 let's just wait for the CI to complete. OK to merge after that? |
Hey :D |
This PR contains part of Thomas Durantel's PhD work