Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TWal this is the first PR of possibly many attempting to restore the JS build of MLS*
This needs FStarLang/FStar#3202 to be merged first.
What this PR does is:
Can you please add a
dune build
target to the Makefile to make sure that this remains on CI? I'm not sure if this should go under all or check.The next steps are:
node js/test.js
or equivalent to the build to make sure this doesn't regress