refactor: remove multiple imports + uppercase constants #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QRuhier
commented
Oct 18, 2024
QRuhier
commented
- create a const for regrouping all the import.meta.env.VITE_EXTERNAL_RESOURCES_URL
- write in uppercase all the consts with a hard-coded value (see https://javascript.info/variables#uppercase-constants)
|
chloe-renaud
approved these changes
Oct 18, 2024
laurentC35
added a commit
that referenced
this pull request
Oct 29, 2024
* build: add env var for talking surveys * feat(#240): add capmi app to the router rules * feat(#242): inject externalResources script at start * feat(#238): add global variable before initalize with Lunatic fix: #238 * fix: types in LunaticData * fix: types again We use only one function to initalize surveyUnit correctly Co-Authored-By: Quentin Ruhier <99256289+QRuhier@users.noreply.github.com> * feat(#231): add external service-worker in condition where VITE_EXTERNAL_RESOURCES_URL is defined (#252) fix: #231 * feat: add talking questionnaires synchro (#246) * feat: get externalResources during synchronization * chore: add comments & remove unused imports/exports * fix: get external resources only for needed questionnaires * feat: delete external resources for not needed questionnaires * feat: delete external resources root-cache if no external questionnaire needed * feat: handle progress bar for external resources synchro * fix: handle promises for external resources * perf: optimize cache lookup during external resources synchronization * feat : handle errors on fetching external url * chore: remove unused functions & imports * feat: delete old external resources caches * docs: add external resources synchronization * refactor: simplify externalResources functions * test: set vitest * test: add tests for external resources synchro * fix: import const * ci: add test in jobs * ci: remove condition on target branch for pull_request * ci: fix test job * test : fix sonar config * docs : update external resources synchro * docs: improve external resources synchro * refactor: remove multiple imports + uppercase constants (#257) * refactor : set const for imports of env var VITE_EXTERNAL_RESOURCES_URL * refactor: uppercase constants * refactor: regroup core exported constants * chore: remove unused import * fix: duplicate export * test(sonar) : fix coverage config * ci : adapt CI for tests & sonar * ci: rename ci & jobs --------- Co-authored-by: Quentin Ruhier <quentin.ruhier@insee.fr> Co-authored-by: Quentin Ruhier <99256289+QRuhier@users.noreply.github.com> Co-authored-by: Emmanuel DEMEY <demey.emmanuel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.