negative value for array variables when resizing (#1151)

InseeFr · Sep 25, 2024 · d699cb9 · d699cb9
1 parent cff24a0
commit d699cb9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/stories/input-number/source.json b/src/stories/input-number/source.json
@@ -17,6 +17,7 @@
 			"response": { "name": "NB" }
 		}
 	],
+	"resizing": { "NB": { "size": "NB", "variables": ["NAMES"] } },
 	"variables": [
 		{
 			"variableType": "COLLECTED",
@@ -28,6 +29,17 @@
 				"EDITED": null,
 				"INPUTED": null
 			}
+		},
+		{
+			"variableType": "COLLECTED",
+			"name": "NAMES",
+			"values": {
+				"PREVIOUS": null,
+				"COLLECTED": [null],
+				"FORCED": null,
+				"EDITED": null,
+				"INPUTED": null
+			}
 		}
 	]
 }
diff --git a/src/use-lunatic/reducer/commons/resize-array-variable.ts b/src/use-lunatic/reducer/commons/resize-array-variable.ts
@@ -6,10 +6,14 @@ function resizeArrayVariable<T = unknown>(
 	length: number,
 	defaultValue?: T
 ): T[] {
+	if (length < 0) {
+		return [];
+	}
 	if (!Array.isArray(array)) {
 		// create the array
 		return new Array(length).fill(defaultValue);
-	} else if (array.length !== length) {
+	}
+	if (array.length !== length) {
 		// renew array end keep previous values
 		return new Array(length)
 			.fill(defaultValue)