Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoleBinding created when triming suffix is not valid #191

Closed
Donatien26 opened this issue Dec 19, 2022 · 0 comments
Closed

RoleBinding created when triming suffix is not valid #191

Donatien26 opened this issue Dec 19, 2022 · 0 comments
Assignees

Comments

@Donatien26
Copy link
Contributor

When adding a trim of the namespace suffix the corresponding rolebinding (giving rights to user) look like this:

Name:         namespace_admin
Labels:       created_by=onyxia
Annotations:  <none>
Role:
  Kind:  ClusterRole
  Name:  admin
Subjects:
  Kind   Name                    Namespace
  ----   ----                    ---------
  Group  oidc-grp-test           projet-test

The first column is the combinaison of prefix (added by the oidc-proxy on api server) and the group on which we want to give access on the group. The group must not be cut. For example i have the following group in my token : test_K8S, I want to cut the _K8S for the project but to keep the suffix for the name. Tell me if it's not clear

Expected:

Name:         namespace_admin
Labels:       created_by=onyxia
Annotations:  <none>
Role:
  Kind:  ClusterRole
  Name:  admin
Subjects:
  Kind   Name                    Namespace
  ----   ----                    ---------
  Group  oidc-grp-test_K8S       projet-test
@CChemin CChemin self-assigned this Dec 20, 2022
CChemin added a commit to CChemin/onyxia-api that referenced this issue Dec 20, 2022
CChemin added a commit to CChemin/onyxia-api that referenced this issue Dec 20, 2022
CChemin added a commit to CChemin/onyxia-api that referenced this issue Dec 20, 2022
CChemin added a commit to CChemin/onyxia-api that referenced this issue Dec 20, 2022
@fcomte fcomte closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants