Create a secret for Onyxia's services configuration #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Can you give a brief description of what this PR introduce? 😊 |
|
This PR modify how we manage metadata for specific onyxia information. Before this PR those metadata (owner, share, friendly name) was kept inside helm values. This PR manage those metadata inside onyxia specific secrets. Those secrets are deleted if thé release IS delete without onyxia because of the ownerReference referencing the helm release secrets |
|
It will also enable the modification of friendly name ans the sharing status without update the release |
|
This looks ok to me. |
olevitt
approved these changes
May 21, 2024
olevitt
requested changes
May 21, 2024
onyxia-api/src/main/java/fr/insee/onyxia/api/services/impl/HelmAppsService.java
Outdated
Show resolved
Hide resolved
|
olevitt
approved these changes
Jun 10, 2024
olevitt
added
enhancement
olevitt
changed the title
olevitt
changed the title
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intend to manage metadata of an onyxia release inside a secret with a owner reference pointing on the helm secret to ensure that those metadata will be remove when the release is deleted.
This PR also create two endpoint to modify the friendly name and the shared status of an existing release.
This PR also modify attributes of a release ( to add thoses metadata : owner , share, friendlyname and catalogID ) and the body of the request when a user create a release.