Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OperatorSDK (1.27.0 -> 1.31.0) and Kubebuilder (go/v3 -> go/v4) #18

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

phlg
Copy link
Contributor

@phlg phlg commented Aug 2, 2023

Work very much in progress.

This merge requests aims at updating Operator SDK, following the version-by-version guidelines documented here : https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.31.0/ ; this probably encompasses several PRs made by renovate, but they should (... I think ?) come as a coherent bundle "approved" by Operator SDK, instead of isolated PRs.

A first step was done with 5661ada ; this implemented the changes documented in aforementioned website starting from 1.28.0 all the way to 1.31.0 included, safe for two things :

For future reference, the actual release notes on the Operator SDK Github repo (https://github.com/operator-framework/operator-sdk/releases) appear to be of much better quality than the upgrade documentation on their website. For instance, the upgrade documentation for 1.30.0 appears to be a copy-pasted placeholder, while there are in fact a few actual changes visible in the 1.30.0 release note.

(still using go/v3 for kubebuilder, updating to go/v4alpha or go/v4, as mentioned in https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/)
@phlg phlg self-assigned this Aug 2, 2023
@phlg
Copy link
Contributor Author

phlg commented Aug 2, 2023

The image built with the first commit was deployed in-house, and didn't generate any error. This is a very rough testing, but still better than nothing I guess.

phlg added 4 commits August 7, 2023 10:14
(before go.mod update, and before eventual manifest regeneration)
Followed kubebuilder's migration guide instead of OperatorSDK v1.28.0 upgrade notes
@phlg
Copy link
Contributor Author

phlg commented Aug 7, 2023

The changes in 5ac28ef through 1e96f19 are all related to upgrading kubebuilder from go/v3 to go/v4.

The image obtained after theses commits was again locally tested and did not seem to generate any error, so hopefully the update should be bug-free. And if not, it will be an argument in favor of spending some time to implement actual tests in this operator.

@phlg phlg marked this pull request as ready for review August 7, 2023 13:11
@phlg phlg merged commit a0ec52a into main Aug 7, 2023
@phlg phlg mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant