Add KOIN_USE_COMPOSE_VIEWMODEL key to replace USE_COMPOSE_VIEWMODEL #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIMULATAN
reviewed
Aug 24, 2024
| private fun isComposeViewModelActive(): Boolean { | ||
| logger.warn("Use Compose ViewModel for @KoinViewModel generation") | ||
| logger.warn("[Deprecated] Please use KOIN_USE_COMPOSE_VIEWMODEL arg") |
There was a problem hiding this comment.
Why isn't this behind a check if the argument is actually set? I don't even use Compose and this deprecation notice is still printed.
There was a problem hiding this comment.
is it still present?
There was a problem hiding this comment.
As of 1.4.0-RC4, yes. Even when explicitly disabling USE_COMPOSE_VIEWMODEL.
Looking at the code, it appears the isComposeViewModelActive is called in any case, leading to the message being logged without any further checks.
https://github.com/InsertKoinIO/koin-annotations/blob/1.4.0-RC4/projects/koin-ksp-compiler/src/jvmMain/kotlin/org/koin/compiler/BuilderProcessor.kt#L83-L87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KOIN_USE_COMPOSE_VIEWMODEL key to replace USE_COMPOSE_VIEWMODEL