Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning args warning #173

Merged

Conversation

kibettheophilus
Copy link
Contributor

The warning below is still shown when KOIN_USE_COMPOSE_VIEWMODEL arg is used.

w: [ksp] [Deprecated] 'USE_COMPOSE_VIEWMODEL' arg is deprecated. Please use 'KOIN_USE_COMPOSE_VIEWMODEL'
w: [ksp] Activate Compose ViewModel for @KoinViewModel generation

I see the USE_COMPOSE_VIEWMODEL is to be deprecated after Koin 4.0, so I am not sure if this PR is really viable...we can close it if not.

@kibettheophilus kibettheophilus changed the base branch from main to 1.4.0 September 27, 2024 06:30
@kibettheophilus kibettheophilus marked this pull request as ready for review September 27, 2024 06:31
@arnaudgiuliani
Copy link
Member

Yes, that was a bit dummy :D Thanks @kibettheophilus

@arnaudgiuliani arnaudgiuliani added this to the 1.4.0 milestone Oct 15, 2024
@arnaudgiuliani arnaudgiuliani added the status:accepted Ticket is accepted and will be planned in a milestone label Oct 15, 2024
@arnaudgiuliani arnaudgiuliani merged commit b86d111 into InsertKoinIO:1.4.0 Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Ticket is accepted and will be planned in a milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants