Skip to content

Commit

Permalink
[Maintenance] remove useless NoClass, use kotlin.Nothing instead
Browse files Browse the repository at this point in the history
  • Loading branch information
luozejiaqun committed Jan 23, 2025
1 parent 5f1f158 commit 6fbb98d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
package org.koin.core.instance

import org.koin.core.annotation.KoinInternalApi
import org.koin.core.logger.Logger
import org.koin.core.parameter.ParametersHolder
import org.koin.core.qualifier.Qualifier
Expand All @@ -36,6 +35,3 @@ class ResolutionContext(
){
val debugTag = "t:'${clazz.getFullName()}' - q:'$qualifier'"
}

@KoinInternalApi
class NoClass
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ import org.koin.core.definition.IndexKey
import org.koin.core.definition.Kind
import org.koin.core.definition._createDefinition
import org.koin.core.definition.indexKey
import org.koin.core.instance.ResolutionContext
import org.koin.core.instance.InstanceFactory
import org.koin.core.instance.NoClass
import org.koin.core.instance.ResolutionContext
import org.koin.core.instance.ScopedInstanceFactory
import org.koin.core.instance.SingleInstanceFactory
import org.koin.core.module.Module
Expand Down Expand Up @@ -91,7 +90,7 @@ class InstanceRegistry(val _koin: Koin) {
}

private fun createEagerInstances(instances: Collection<SingleInstanceFactory<*>>) {
val defaultContext = ResolutionContext(_koin.logger, _koin.scopeRegistry.rootScope, clazz = NoClass::class)
val defaultContext = ResolutionContext(_koin.logger, _koin.scopeRegistry.rootScope, clazz = Nothing::class)
instances.forEach { factory -> factory.get(defaultContext) }
}

Expand Down

0 comments on commit 6fbb98d

Please sign in to comment.