Fix parameters stability inject #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arnaudgiuliani
commented
Dec 17, 2024
arnaudgiuliani
commented
- Fix ParametersHolder equals/hascode
- Fix koinInject function to stabilize new parameters
Nek-12
reviewed
Jan 3, 2025
| scope.get(qualifier) { | ||
| currentParameters?.invoke() ?: emptyParametersHolder() | ||
| } | ||
| val params: ParametersHolder? = parameters?.invoke() |
There was a problem hiding this comment.
This is incorrect as it will recreate parameters on every recomposition
| @@ -139,6 +139,16 @@ open class ParametersHolder( | |||
| } | |||
|
|
|||
| override fun toString(): String = "DefinitionParameters${_values.toList()}" | |||
|
|
|||
| override fun equals(other: Any?): Boolean { | |||
| if (other is ParametersHolder){ | |||
There was a problem hiding this comment.
This is incorrect as the equals check is unstable for parameter subclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.