Disable property type cast to fix issue gh-291

[Swordsman-Inaction]

Fixes #291

Two changes(Breaking changes):

• Disable property type cast, now property value can only be String
• Add extension functions for int and float properties.

Before:

• getKoin().getProperty<Int>("int.value")
• getKoin().getProperty<Float>("float.value")

Now:

• getKoin().getIntProperty("int.value")
• getKoin().getFloatProperty("float.value")

[arnaudgiuliani]

Good job, thanks for your contribution.

Just renamed it as KoinPropertyExt.kt, can you test it?

[arnaudgiuliani]

Please also check conflicts

[Swordsman-Inaction]

@arnaudgiuliani Updated and tested.
But the MVVMActivity in androidx-samples project is crashing because of this change: 53c07fb#diff-2263db8ed8a57c624f749b4114746255R45

[jeziellago]

@arnaudgiuliani Updated and tested.
But the MVVMActivity in androidx-samples project is crashing because of this change: 53c07fb#diff-2263db8ed8a57c624f749b4114746255R45

#795 should fix androidx-samples.
https://github.com/InsertKoinIO/koin/pull/795/files#diff-2263db8ed8a57c624f749b4114746255R53

[arnaudgiuliani]

Ok, will check that asap 👍

[arnaudgiuliani]

just merged the PR

[arnaudgiuliani]

can you double check @Swordsman-Inaction ? 🙏

[Swordsman-Inaction]

@arnaudgiuliani Just merged 2.1.x, all good now.

[chrisjenx]

Don't wanna be that guy - but yo - this really does not go into a bugfix release! this is a Major a release at best, Minor release at worst. If you are going to use semver at least respect it!

[Satook]

I agree with @chrisjenx. This is a backward incompatible change. I'm stuck on 2.1.5 until I change how I pass config data around my app.

FYI: I'm using Ktor which has a richer ApplicationConfig (it supports nesting and lists of values). Means I'll have to stop using properties and move it over to an injectable parameter.

Would a patch that keeps the same external interface (getProperty, getIntProperty, getFloatProperty) be accepted? I'd add getAnyProperty or getTypedProperty and swap the map back to <string, any>. This way we can keep the string oriented interfaces for people who just want a flat PropertyList style but give others in my situation a good migration path.

[antohaby]

This file isn't complete enough.
On the previous version getProperty was accessible from Scope as well.

For example:

single {
    ConnectionPool (
        maxConnections = getIntProperty("CONNECTION_POOL__MAX_CONNECTIONS")
    )
}

is not going to work, but should IMHO.