Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add Label PR GitHub Action #1721

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Mar 23, 2020

Applies a PR based the title prefix, which defaults to the commit prefix
for single-commit topics.

Closes #60

Note: this will be currently limited to PR's created from InsightSoftwareConsortium/ITK branches (requires repository write permission) per:

We could experiment with developers with write access creating PR's from the ITK repository.

Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Matt !

Should it have started applying labels to this PR as well?

@thewtex
Copy link
Member Author

thewtex commented Mar 24, 2020

Should it have started applying labels to this PR as well?

Due to the GitHub Action permission limitations referenced in the description, it was not expected to work on this forked pull request, but it should not fail :-(.

Continuing the discussion with the author at srvaroa/labeler#3

Applies a PR based the title prefix, which defaults to the commit prefix
for single-commit topics.
@thewtex
Copy link
Member Author

thewtex commented Apr 22, 2020

@svoraroa has fixed this so it no longer fails as a false-positive on forks. 🙏 We may want to wait until it can be executed as a cron job for merge.

@dzenanz
Copy link
Member

dzenanz commented Jun 23, 2020

Is this ready for merge @thewtex?

@thewtex
Copy link
Member Author

thewtex commented Jun 23, 2020

We can go ahead and merge it.

@thewtex thewtex merged commit 3f35ca3 into InsightSoftwareConsortium:master Jun 23, 2020
@thewtex thewtex deleted the labeller-action branch June 23, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a bot to automatically add GitHub issue labels based on commit prefixes
3 participants