-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Trigger PR labeler workflows from forks #2438
ENH: Trigger PR labeler workflows from forks #2438
Conversation
Change the `GitHub` webhook event to a `pull_request_target` event to trigger the PR labeler workflows from forks. See documentation: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target and https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
Let's see if this makes the trick. If the events are triggered too frequently, once that is verified, we may want to restrict them to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a great improvement if it worked.
If this works, will it allows us to also apply clang-format on PRs from forks? |
Not 100% sure how the commands throughout the comments on a PR work, but chances are that it might. Edit: not sure if the current clang-format command is triggered using the kwrobot-1 actions, but this action seems to have the ability to trigger such processes. |
😭 The Actions failed: The webhook event is not supported yet: 😔. |
Should we revert this PR? |
Not sure; the workflow does not show the error in the PR/marks the check as passing, and hence it will not be considered as an unsuccessful check when merging the PRs (somewhat similar to what it was before). Maybe we could track it as an issue? But even then, we purely depend on the author of the labeler action or someone else (I think I might not have the bandwidth to learn We could ask to the google folks if they will merge it, or propose the labeler action repo owner to switch to track the Edit: another option is to use other labeler actions; I have not found any doing both tasks (labeling according to the PR title and the changed files), but there are some that do one or the other, so we would have two workflows. |
Change the
GitHub
webhook event to apull_request_target
event totrigger the PR labeler workflows from forks.
See documentation:
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
and
https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
PR Checklist