Fix types of arguments passed to Set member function calls in unit tests
#3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `EllipseSpatialObject::SetCenterInObjectSpace` should have a point as argument, not an offset. Bug found by locally (temporarily) declaring converting constructors of `itk::Point` "explicit".
The `SetInsideValue` and `SetOutsideValue` member functions of `BinaryThresholdImageFilter<InternalImageType, RGBImageType>` expect an RGB pixel value as argument, not just a single `unsigned short` value! Issue found by locally (temporarily) declaring the converting constructor `RGBPixel(const ComponentType &)` "explicit".
github-actions
bot
added
area:Registration
dzenanz
approved these changes
Feb 24, 2022
hjmjohnson
approved these changes
Feb 24, 2022
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 27, 2022
Prevented implicit conversion of a value to `Point`. Aims to avoid possible flaws, like the ones addressed by: Pull request InsightSoftwareConsortium#3225 commit 5b71d63 "BUG: Quick-fix ContourSpatialObject::Update(), LINEAR_INTERPOLATION case" Pull request InsightSoftwareConsortium#3228 commit 12a501c "BUG: Fix `SetCenterInObjectSpace` calls in Registration test" Pull request InsightSoftwareConsortium#3231 commit e4841aa "STYLE: Clarify estimation ray position `RayCastInterpolateImageFunction`" Deleted `Point(nullptr_t)`, especially to avoid `PointType p = 0`.
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 28, 2022
Prevented implicit conversion of a value to `Point`. Aims to avoid possible flaws, like the ones addressed by: Pull request InsightSoftwareConsortium#3225 commit 5b71d63 "BUG: Quick-fix ContourSpatialObject::Update(), LINEAR_INTERPOLATION case" Pull request InsightSoftwareConsortium#3228 commit 12a501c "BUG: Fix `SetCenterInObjectSpace` calls in Registration test" Pull request InsightSoftwareConsortium#3231 commit e4841aa "STYLE: Clarify estimation ray position `RayCastInterpolateImageFunction`" Deleted `Point(nullptr_t)`, especially to avoid `PointType p = 0`.
hjmjohnson
pushed a commit
that referenced
this pull request
Feb 28, 2022
Prevented implicit conversion of a value to `Point`. Aims to avoid possible flaws, like the ones addressed by: Pull request #3225 commit 5b71d63 "BUG: Quick-fix ContourSpatialObject::Update(), LINEAR_INTERPOLATION case" Pull request #3228 commit 12a501c "BUG: Fix `SetCenterInObjectSpace` calls in Registration test" Pull request #3231 commit e4841aa "STYLE: Clarify estimation ray position `RayCastInterpolateImageFunction`" Deleted `Point(nullptr_t)`, especially to avoid `PointType p = 0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.