BUG: Mark LabelGeometryImageFilter as deprecated

[blowekamp]

The LabelGeometryImageFilter has known computational inefficiencies and bugs such as some attributes are not computed with respect to image geometry.

This class is currently in the Review module and is planned to be moved to the Compatibility group under the Deprecated module.

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)
• Added test (or behavior not changed)
• Updated API documentation (or API not changed)
• Added license to new files (if any)
• Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
• Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

[blowekamp]

The intention is to produce a warning for the current up common release so that with 5.0 6.0 the class can be moved to the deprecated module.

[dzenanz]

Looks good. You mean to be moved to Deprecated module in 6.0, not 5.0?

[blowekamp]

It does not look like the the ITKReview module has recently receive style changes.

[dzenanz]

Maybe because it is off by default?

[dzenanz]

Perhaps we should turn it on by default (low effort), of finish migration of content out of it and into other corresponding modules (high effort)?

[gdevenyi]

@ntustison @cookpa

[blowekamp]

Perhaps we should turn it on by default (low effort), of finish migration of content out of it and into other corresponding modules (high effort)?

I think turning it on by default may encourage more usage, and limit options available to the remaining classes. I Think the options for the classes in the Review module should be 1) Integrate in ITK proper after changes, 2) make a remote module 3) move to the Deprecate module.

[thewtex]

👍

[blowekamp]

@thewtex I see you tagged ITK6.0 beta with this PR. So what would be the scheduled to move this class the the ITK Deprecated module? ITK 7.0?

This filter is only in ITKReview, so perhaps less notification is needed?

[thewtex]

This filter is only in ITKReview, so perhaps less notification is needed?

ITKReview is relied on in practice, but it would be helpful to have it marked as deprecated if you would like to move to ITKDeprecated in ITK 6. Merged.