Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Fixed Cpp Warnings #4667

Merged
merged 1 commit into from
May 15, 2024
Merged

COMP: Fixed Cpp Warnings #4667

merged 1 commit into from
May 15, 2024

Conversation

andrei-sandor
Copy link
Contributor

Fixed the following warnings

-Wimplicit-fallthrough
-Wzero-as-null-pointer-constant
-Wdeprecated-dynamic-exception-spec

@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module labels May 15, 2024
@andrei-sandor
COMP: Fixed Cpp Warnings
904c7c5 
Fixed the following clang warnings

-Wimplicit-fallthrough
-Wdeprecated-dynamic-exception-spec
thewtex
thewtex approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrei-sandor thank you!

@thewtex thewtex merged commit 4169e4b into InsightSoftwareConsortium:master May 15, 2024
14 checks passed
@andrei-sandor
Copy link
Contributor Author

@andrei-sandor thank you!

@dzenanz @thewtex. I thank you. It was a pleasure to write PRs for ITK. I learned a lot form the code and from your valuable comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-Dekker N-Dekker N-Dekker left review comments

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrei-sandor @thewtex @dzenanz @N-Dekker