BUG: Missing writing of the nifti descrip field. #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Bug
dzenanz
approved these changes
Aug 20, 2024
|
Hi @dzenanz, please rerun the failed test if needed (it isn't related to this change) and merge when it passes. Thanks. |
|
This will need to be rebased on top of #4811, after it gets merged. I plan to merge that as soon as its CI finished. |
|
@dzenanz I did a quick search and didn't find it. But for patches for 5.4 what is the order of merging for master, release, releaes-5.4? |
|
I think merge into most specific first. So first merge topic branch into |
|
#4811 has now been merged. A plain rebase should be sufficient for a green CI. |
The nifti descrip field is currently only read and exposed via the ITK_FileNotes metadata dictionary variable. Setting the ITK_FileNotes via the metadata dictionary has no effect while writing. This commit writes the contents of the ITK_FileNotes variable if it is found in the metadata dictionary.
|
Rebased and force pushed. |
|
I merged it to |
|
Thanks. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nifti descrip field is currently only read and exposed via the ITK_FileNotes metadata dictionary variable. Setting the ITK_FileNotes via the metadata dictionary has no effect while writing. This commit writes the contents of the ITK_FileNotes variable if it is found in the metadata dictionary.