Remove p->Initialize() calls directly after p = T::New(), in tests and example
#4976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Examples
N-Dekker
force-pushed
the
Remove-Initialize-after-New-in-tests-and-example
branch
from
f36f144 to
d6a113b
Compare
dzenanz
approved these changes
Nov 21, 2024
N-Dekker
commented
Nov 21, 2024
Modules/Numerics/Statistics/test/itkWeightedCentroidKdTreeGeneratorTest9.cxx
Show resolved
Hide resolved
For most ITK types, `p->Initialize()` has no effect, directly after `p = T::New()`, so the `Initialize()` call might as well be removed. Excluded a `randomNumberGenerator->Initialize()` call from this commit, as that call appears to actually have an effect (randomizing the seed). - Follow-up to pull request InsightSoftwareConsortium#4972 commit 674b3d2 "STYLE: Remove `p->Initialize()` calls directly after `p = T::New()`"
- Follow-up to pull request InsightSoftwareConsortium#4972 commit 674b3d2 "STYLE: Remove `p->Initialize()` calls directly after `p = T::New()`"
N-Dekker
force-pushed
the
Remove-Initialize-after-New-in-tests-and-example
branch
from
d6a113b to
04cde48
Compare
hjmjohnson
approved these changes
Nov 22, 2024
hjmjohnson
merged commit bc044c1
into
InsightSoftwareConsortium:master
17 checks passed
N-Dekker
added a commit
to N-Dekker/ITKSphinxExamples
that referenced
this pull request
Nov 27, 2024
When a point set is just created by `New()`, it is already properly initialized. - Follow-up to pull request InsightSoftwareConsortium/ITK#4976 commit InsightSoftwareConsortium/ITK@bc044c1 "STYLE: Remove p->Initialize() call after p = T::New() in example"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p->Initialize()calls directly afterp = T::New()#4972