Skip to content

Commit

Permalink
ENH: Fix Node.js warnings linked to GitHub actions
Browse files Browse the repository at this point in the history
Fix `Node.js` warnings linked to GitHub actions: bump
`actions/checkout@v4`.

Take advantage of the commit to bump `upload-artifact@v4` and
`actions/setup-python@v5`.

Fixes:
```
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3.
For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

raised for example in:
https://github.com/InsightSoftwareConsortium/ITKTrimmedPointSetRegistration/actions/runs/9753007352
  • Loading branch information
jhlegarreta committed Jul 2, 2024
1 parent 0d54bc7 commit d044cd1
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/build-test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
python-version: ["38", "39", "310", "311"]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: 'Free up disk space'
run: |
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
done
- name: Publish Python package as GitHub Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: LinuxWheel${{ matrix.python-version }}
path: Evaluated/ITKModuleTemplate/dist
Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:
../../macpython-download-cache-and-build-module-wheels.sh
- name: Publish Python package as GitHub Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: MacOSWheels
path: Evaluated/ITKModuleTemplate/dist
Expand All @@ -257,15 +257,15 @@ jobs:
python-version-minor: ["8", "9", "10", "11"]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: 'Install Python'
run: |
$pythonArch = "64"
$pythonVersion = "3.${{ matrix.python-version-minor }}"
iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/scikit-build/scikit-ci-addons/master/windows/install-python.ps1'))
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.x'

Expand Down Expand Up @@ -315,7 +315,7 @@ jobs:
C:\Python3${{ matrix.python-version-minor }}-x64\python.exe C:\P\IPP\scripts\windows_build_module_wheels.py --py-envs "3${{ matrix.python-version-minor }}-x64"
- name: Publish Python package as GitHub Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: WindowWheel3.${{ matrix.python-version-minor }}
path: Evaluated/ITKModuleTemplate/dist
2 changes: 1 addition & 1 deletion .github/workflows/clang-format-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: InsightSoftwareConsortium/ITKClangFormatLinterAction@master
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: InsightSoftwareConsortium/ITKClangFormatLinterAction@master

0 comments on commit d044cd1

Please sign in to comment.