Skip to content

itk v5.4rc04 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2024
Merged

itk v5.4rc04 #158

merged 4 commits into from
Apr 22, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 19, 2024 •
edited by dzenanz
Loading

  • ENH: Migrate to scikit-build-core, pyproject.toml
  • DOC: Add note on scikit-build-core migration
  • DOC: Point CI documentation to ITKRemoteModuleBuildTestPackageAction
  • ENH: Update CI for ITK 5.4 RC 04

Closes #156.

thewtex added 3 commits April 19, 2024 06:40
@thewtex
ENH: Migrate to scikit-build-core, pyproject.toml
1257b25 
scikit-build-core offers a declarative, convenient build configuration based on
modern Python packaging standards.

Other advantages include support for the Stable ABI.
@thewtex
DOC: Add note on scikit-build-core migration
f07383c 
How and why to migrate.
@thewtex
DOC: Point CI documentation to ITKRemoteModuleBuildTestPackageAction
e2c165d 
Redirect further information to its repository README, which is extremely well documented.
@thewtex
ENH: Update CI for ITK 5.4 RC 04
d4afa39 
Update the configuration of the cookiecutter CI to point to the HEAD of
ITKRemoteModuleBuildTestPackageAction's v5.4.0 branch.

Updates to the template's configuration.
@thewtex thewtex mentioned this pull request Apr 19, 2024
Closed
@dzenanz
Copy link
Member

dzenanz commented Apr 19, 2024

Should notebook tests be addressed in this PR? I think that this line needs to be updated to match one of the new package names. Sample failure here: https://github.com/InsightSoftwareConsortium/ITKMontage/actions/runs/8756600891/job/24036846657?pr=225.

@thewtex
Copy link
Member Author

thewtex commented Apr 20, 2024 •
edited
Loading

Should notebook tests be addressed in this PR? I think that this line needs to be updated to match one of the new package names. Sample failure here: https://github.com/InsightSoftwareConsortium/ITKMontage/actions/runs/8756600891/job/24036846657?pr=225.

Seems to be a separate issue -- when the suffixes were added, that line should have been updated to include _2_28-x64.

@thewtex
Copy link
Member Author

thewtex commented Apr 22, 2024

Seems to be a separate issue -- when the suffixes were added, that line should have been updated to include _2_28-x64.

patch: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#82

@dzenanz dzenanz merged commit 2be9af0 into InsightSoftwareConsortium:main Apr 22, 2024
@thewtex thewtex mentioned this pull request Apr 22, 2024
Closed
@jhlegarreta jhlegarreta mentioned this pull request Apr 22, 2024
Closed
@jhlegarreta jhlegarreta mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@jhlegarreta jhlegarreta Awaiting requested review from jhlegarreta

@jcfr jcfr Awaiting requested review from jcfr

@phcerdan phcerdan Awaiting requested review from phcerdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update actions to use Node 20
2 participants
@thewtex @dzenanz