feat: add set_image_piecewise_function_points #755
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
itkwidgets/_type_aliases.py
Outdated
|
|
||
| Gaussian_Curve = Dict[str, float] | ||
| Gaussians = Dict[str, List[Gaussian_Curve]] | ||
| Points2d = List[Tuple[float, float]] |
There was a problem hiding this comment.
This could be
Sequence[Sequence[float, float]]
? Please check if variants work by passing them to the set_* method. If they do not work, then it may be worthwhile type casting with list() or tuple() to provide a more convenient interface for the caller.
In the documentation example there is:
[[.2, .1], [.8, .9]]
which is a List[List[float, float]].
There was a problem hiding this comment.
Ah, yes. Updated type to Sequence[Sequence[float]]. Sequence can't do Sequence[float, float]. Passing tuple points or list points works. Passing 3D point bugs out TF editor =/
itkwidgets/_initialization_params.py
Outdated
| @@ -22,7 +22,7 @@ def init_params_dict(itk_viewer): | |||
| 'gradient_opacity': itk_viewer.setImageGradientOpacity, | |||
| 'gradient_opacity_scale': itk_viewer.setImageGradientOpacityScale, | |||
| 'interpolation': itk_viewer.setImageInterpolationEnabled, | |||
| 'gaussians': itk_viewer.setImagePiecewiseFunctionGaussians, | |||
| 'piecewise_function_points': itk_viewer.setImagePiecewiseFunctionPoints, | |||
There was a problem hiding this comment.
How about tf_points or something else shorter here?
There was a problem hiding this comment.
Or the more specific transfer_function_points?
There was a problem hiding this comment.
Changed to transfer_function_points
There was a problem hiding this comment.
@PaulHax thank you! How about transfer_function for brevity? I do not think _points is adding enough information to warrant the length for interactive use. They are always points and this is implicit in the specification.
There was a problem hiding this comment.
Better and better. Changed.
PaulHax
force-pushed
the
tf-points
branch
2 times, most recently
from
807300c to
883440d
Compare
remove set_image_piecewise_function_gaussians
remove set_image_piecewise_function_gaussians
Depends on
Kitware/itk-vtk-viewer#751