Skip to content

test: fix show manual survey e2e test #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

test: fix show manual survey e2e test #497

merged 1 commit into from
Aug 6, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Aug 6, 2024

Description of the change

The "Show Manual Survey" E2E test started to fail due to the over-scrolling causing the "Show Manual Survey" button to not be visible on the screen.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-15324

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev marked this pull request as draft August 6, 2024 08:22
@a7medev a7medev self-assigned this Aug 6, 2024
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
Dart 82.3% ✅

Generated by 🚫 dangerJS against a8175c7

@a7medev a7medev marked this pull request as ready for review August 6, 2024 08:31
@mzelzoghbi mzelzoghbi merged commit 4832a23 into master Aug 6, 2024
11 checks passed
@mzelzoghbi mzelzoghbi deleted the test/fix-survey-test branch August 6, 2024 09:16
ahmedAlaaInstabug pushed a commit that referenced this pull request Nov 4, 2024
@a7medev @ahmedAlaaInstabug
test: fix show manual survey e2e test (#497)
0e22771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@ahmedAlaaInstabug ahmedAlaaInstabug Awaiting requested review from ahmedAlaaInstabug

@mzelzoghbi mzelzoghbi Awaiting requested review from mzelzoghbi

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7medev @InstabugCI @AndrewAminInstabug @mzelzoghbi