Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Changelog
## [Unreleased](https://github.com/Instabug/Instabug-Flutter/compare/v14.1.0...dev)

### Fixed

- Fixed an issue with `SetReproStepsConfig` on Android platform ([#543](https://github.com/Instabug/Instabug-Flutter/pull/543)).

## [14.1.0](https://github.com/Instabug/Instabug-Flutter/compare/v14.0.0...v14.1.0) (December 22, 2024)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import com.instabug.flutter.util.ArgsRegistry;
import com.instabug.flutter.util.Reflection;
import com.instabug.flutter.util.ThreadManager;
import com.instabug.library.ReproMode;
import com.instabug.library.internal.crossplatform.CoreFeature;
import com.instabug.library.internal.crossplatform.CoreFeaturesState;
import com.instabug.library.internal.crossplatform.FeaturesStateListener;
Expand Down Expand Up @@ -334,7 +335,7 @@ public void setReproStepsConfig(@Nullable String bugMode, @Nullable String crash

if (crashMode != null) {
final Integer resolvedCrashMode = ArgsRegistry.reproModes.get(crashMode);
builder.setIssueMode(IssueType.Crash, resolvedCrashMode);
builder.setIssueMode(IssueType.AllCrashes, resolvedCrashMode);
}

if (sessionReplayMode != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ public void testSetReproStepsConfig() {
ReproConfigurations.Builder builder = mReproConfigurationsBuilder.constructed().get(0);

verify(builder).setIssueMode(IssueType.Bug, ReproMode.EnableWithScreenshots);
verify(builder).setIssueMode(IssueType.Crash, ReproMode.Disable);
verify(builder).setIssueMode(IssueType.AllCrashes, ReproMode.Disable);
verify(builder).setIssueMode(IssueType.SessionReplay, ReproMode.Disable);
verify(builder).build();

Expand Down
2 changes: 1 addition & 1 deletion example/ios/InstabugTests/InstabugApiTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ - (void)testSetReproStepsConfig {
[self.api setReproStepsConfigBugMode:bugMode crashMode:crashMode sessionReplayMode:sessionReplayMode error:&error];

OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeBug withMode:IBGUserStepsModeEnable]);
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeCrash withMode:IBGUserStepsModeDisable]);
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeAllCrashes withMode:IBGUserStepsModeDisable]);
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeSessionReplay withMode:IBGUserStepsModeDisable]);
}

Expand Down
2 changes: 1 addition & 1 deletion ios/Classes/Modules/InstabugApi.m
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ - (void)setReproStepsConfigBugMode:(nullable NSString *)bugMode crashMode:(nulla

if (crashMode != nil) {
IBGUserStepsMode resolvedCrashMode = ArgsRegistry.reproModes[crashMode].integerValue;
[Instabug setReproStepsFor:IBGIssueTypeCrash withMode:resolvedCrashMode];
[Instabug setReproStepsFor:IBGIssueTypeAllCrashes withMode:resolvedCrashMode];
}

if (sessionReplayMode != nil) {
Expand Down
6 changes: 3 additions & 3 deletions lib/src/modules/instabug.dart
Original file line number Diff line number Diff line change
Expand Up @@ -449,9 +449,9 @@ class Instabug {
}

return _host.setReproStepsConfig(
bugMode.toString(),
crashMode.toString(),
sessionReplayMode.toString(),
bugMode?.toString(),
crashMode?.toString(),
sessionReplayMode?.toString(),
);
}

Expand Down