Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new NDK crash scenarios to example app #1139

Merged
merged 5 commits into from
Feb 25, 2024
Merged

feat: add new NDK crash scenarios to example app #1139

merged 5 commits into from
Feb 25, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 19, 2024 •
edited
Loading

Description of the change

  1. add new NDK crash scenarios to the example app

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA Ticket: MOB-13796

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@mnoseir
Copy link

mnoseir commented Feb 19, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 47.5% ✅
iOS 41.3% ✅

Generated by 🚫 dangerJS against 30446fe

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 22, 2024
abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort as always, and great work on extending the SDK features in the example ap 👏 🔥 🚀 !! Please check the minor suggestions I've added, and also let's add example scope to the PR title:
feat(example): add new NDK crash scenarios

examples/default/android/app/src/main/cpp/crasher_3.h Outdated Show resolved Hide resolved
examples/default/android/app/src/main/cpp/crasher_3.c Outdated Show resolved Hide resolved
examples/default/android/app/src/main/cpp/crasher_2.h Outdated Show resolved Hide resolved
examples/default/android/app/src/main/cpp/crasher_2.c Outdated Show resolved Hide resolved
examples/default/android/app/src/main/cpp/crasher.c Outdated Show resolved Hide resolved
examples/default/android/app/src/main/cpp/crasher_4.cpp Outdated Show resolved Hide resolved
examples/default/android/app/src/main/cpp/crasher_4.h Outdated Show resolved Hide resolved
@ahmedAlaaInstabug ahmedAlaaInstabug merged commit e306624 into dev Feb 25, 2024
9 of 11 checks passed
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the add/ndk-example-buttons branch February 25, 2024 01:08
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add new NDK crash scenarios to example app (#1139)
d87b19f 
* add: crashes examples to simple app

* feat(example): enable NDK crash
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add new NDK crash scenarios to example app (#1139)
1b2e01d 
* add: crashes examples to simple app

* feat(example): enable NDK crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev Awaiting requested review from a7medev

@abdelhamid-f-nasser abdelhamid-f-nasser Awaiting requested review from abdelhamid-f-nasser

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedAlaaInstabug @mnoseir @abdelhamid-f-nasser