Skip to content

feat(example): add set user identification and attribute #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 29, 2024
Merged

feat(example): add set user identification and attribute #1153

merged 6 commits into from
Feb 29, 2024

Conversation

@ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 26, 2024 •
edited
Loading

Description of the change

  1. simple app: add user identification from in settings screen
  2. simple app: add set the user attributes from in settings screen
Settings Screen
Simulator Screenshot - iPhone 15 Pro Max - 2024-02-26 at 17 14 04

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID = MOB-13917 , MOB-13918

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 26, 2024
@mnoseir
Copy link

mnoseir commented Feb 26, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 47.8% ✅
iOS 41.7% ✅

Generated by 🚫 dangerJS against 704133a

@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to dev February 26, 2024 15:14
@InstabugCI
Copy link
Collaborator

InstabugCI commented Feb 28, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 47.8% ✅
iOS 41.7% ✅

Generated by 🚫 dangerJS against 7f9f358

abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as always !! and I love the added UI components they are amaaaazing ⭐ 🤩 ♥️ !! Please check the suggestions 🙏.

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit 9af3812 into dev Feb 29, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/example-add-set-User-Identifier-button branch February 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a7medev a7medev Awaiting requested review from a7medev

1 more reviewer

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahmedAlaaInstabug @mnoseir @InstabugCI @abdelhamid-f-nasser