Skip to content

feat: refactor mitm proxy script #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2024
Merged

feat: refactor mitm proxy script #1331

merged 1 commit into from
Dec 1, 2024

Conversation

AyaMahmoud148
Copy link
Contributor

Description of the change

change mitm proxy to use env variables (Domain,Token) to be dynamically used

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 98.4% ✅
Android 50.2% ✅
iOS 49.4% ✅

Generated by 🚫 dangerJS against 039a726

ahmedAlaaInstabug
ahmedAlaaInstabug approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@AyaMahmoud148 AyaMahmoud148 merged commit f0de0fd into feat/enterprise-release-post-checks Dec 1, 2024
15 of 16 checks passed
@AyaMahmoud148 AyaMahmoud148 deleted the feat/refactor-mitm-proxy-script branch December 1, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

Assignees

@kholood-ea kholood-ea

@ahmedAlaaInstabug ahmedAlaaInstabug

@AndrewAminInstabug AndrewAminInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyaMahmoud148 @InstabugCI @ahmedAlaaInstabug @kholood-ea @AndrewAminInstabug