-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixit CLI #148
Fixit CLI #148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
===========================================
+ Coverage 59.48% 84.60% +25.12%
===========================================
Files 272 85 -187
Lines 38943 3508 -35435
===========================================
- Hits 23164 2968 -20196
+ Misses 15779 540 -15239
Continue to review full report at Codecov.
|
@jimmylai Can you please look into the pyre error? To avoid those errors I have to put |
any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the suggestion to fix the type error on all _add_arguments
and register_subparser
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing.
Found one more thing can be improved.
Summary
Installation:
Usage:
This PR creates new CLI for fixit module
Please follow this sequence to review this PR:
Note: To support backward compatibility, I have changed existing files
run_rules.py, apply_fix.py etc.
for this cli without affecting previous scripts workflow with a new architecture. Will remove redundant code once this CLI published and more robust.