addressing issue 114: await async rule does not account for decorators #150
Conversation
facebook-github-bot
added
the
CLA Signed
|
Does the expected replacement you added to your tests have some errors? I'm using this instead: Invalid(
"""
class Foo:
@classmethod
async def _method(cls): pass
Foo._method()
""",
expected_replacement="""
class Foo:
@classmethod
async def _method(cls): pass
await Foo._method()
""",
),
Invalid(
"""
class Foo:
@staticmethod
async def _method(): pass
Foo._method()
""",
expected_replacement="""
class Foo:
@staticmethod
async def _method(): pass
await Foo._method()
""",
),However, those tests pass even without chaning |
|
thanks @Kronuz for your correction. Unfortunately I cannot verify or try my changes. I get: (fixit-env) haroldo@KTM:~/github/Fixit$ python3 -m fixit.common.generate_pyre_fixtures AwaitAsyncCallRule Any ideas why the generate_python_fixtures doesn't run on this code? thanks |
|
That's the command I used to generate the fixtures, it should be working. Try removing and re-creating the virtual environment. Other than that, maybe @jimmylai can shed some light on it. |
|
It works for me as the following output. Your dev environment has some issues. You can probably try to delete your venv and follow the steps in README to create. To unblock your work, you also can use my generated fixture. |
Summary
addressing issue 114: await async rule does not account for decorators
Test Plan
tox -e py38 -- fixit.tests.AwaitAsyncCallRule