Add NoRedundantArgumentsSuperRule

[mkniewallner]

Summary

Ensure that calls to super that use the direct parent as a first argument are reported (and autofixed when requested), according to PEP 3135.

This will turn

class Foo(Bar):
    def foo(self, bar):
        super(Foo, self).foo(bar)

into

class Foo(Bar):
    def foo(self, bar):
        super().foo(bar)

The rule also takes into account nested classes, so that this code

class Foo:
    class InnerFoo(Bar):
        def foo(self, bar):
            super(Foo.InnerFoo, self).foo(bar)

gets turned into

class Foo:
    class InnerFoo(Bar):
        def foo(self, bar):
            super().foo(bar)

Test Plan

Test cases have been added to ensure that correctly formatted code is not modified and code that matches the rule reports the issue.

[jimmylai]

Thanks for contributing!
The test cases are comprehensive and make sense.

This rule reminds me some other conventions that can be built as Fixit rules.

1. a method in a class should have self as the first argument.
2. a classmethod in a class should have cls as the first argument.
3. a staticmethod in a class should not have self nor cls as the first argument.

Feel free to build more rules for more Python conventions to help developers write better code faster.

[mkniewallner]

2. a classmethod in a class should have cls as the first argument.

This one is actually already implemented 🙂

[jimmylai]

1. a classmethod in a class should have cls as the first argument.

This one is actually already implemented 🙂

That's great! I almost forget it.