Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pyre type-check errors. #196

Merged
merged 3 commits into from
May 26, 2021
Merged

Fixes pyre type-check errors. #196

merged 3 commits into from
May 26, 2021

Conversation

lisroach
Copy link
Contributor

@lisroach lisroach commented May 26, 2021

Summary

New type errors introduced with the new LibCST version. run_command now takes a list, and cst.BaseString shows up in a new place. #195

Test Plan

pyre --preserve-path check

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2021
@lisroach lisroach linked an issue May 26, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #196 (b227638) into master (59c7a3d) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          91       91           
  Lines        3722     3722           
=======================================
  Hits         3203     3203           
  Misses        519      519           
Impacted Files Coverage Δ
fixit/common/generate_pyre_fixtures.py 33.33% <40.00%> (ø)
fixit/rules/cls_in_classmethod.py 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c7a3d...b227638. Read the comment docs.

@lisroach lisroach merged commit cbef89f into Instagram:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyre failures with LibCST 0.3.19
3 participants