Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix - Cell Reordering in IGListBindingSectionController (viewModels a…
…rray not being updated) (#1274) Summary: - See #1262 (cell reordering using a binding section controller caused problems) ## Changes in this pull request - Added method override in `IGListBindingSectionController` to update the internal `viewModels` array after a cell has been moved - Subclasses of IGListBindingSectionController require to call super Issue fixed: #1262 I've added a test for this change. Is this enough? Or should I add more corner cases or something? ### Checklist Some tests fail, but they do seem unrelated. I don't know if this is normal. I haven't changed anything regarding those failing tests. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1274 Reviewed By: candance Differential Revision: D15592822 Pulled By: lorixx fbshipit-source-id: d81c18bec0ad0a6a6613089245352bb182a92f26
- Loading branch information