Address PR review comments

Instagram · Dec 29, 2016 · 2d60457 · 2d60457
1 parent 12c5587
commit 2d60457
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Source/IGListAdapterUpdater.m b/Source/IGListAdapterUpdater.m
@@ -154,7 +154,7 @@ - (void)performBatchUpdatesWithCollectionView:(UICollectionView *)collectionView
  // if the collection view isn't in a visible window, skip diffing and batch updating. execute all transition blocks,
  // reload data, execute completion blocks, and get outta here
  BOOL iOS83OrLater = (NSFoundationVersionNumber >= NSFoundationVersionNumber_iOS_8_3);
- if (iOS83OrLater && _skipsDiffingWhenOffscreen && collectionView.window == nil) {
+ if (iOS83OrLater && self.skipsDiffingWhenOffscreen && collectionView.window == nil) {
  [self beginPerformBatchUpdatestoObjects:toObjects];
  executeUpdateBlocks();
  [self cleanupUpdateBlockState];

diff --git a/Tests/IGListAdapterUpdaterTests.m b/Tests/IGListAdapterUpdaterTests.m
@@ -459,8 +459,7 @@ - (void)test_whenCallingReloadData_withUICollectionViewFlowLayout_withEstimatedS
  XCTAssertEqual([collectionView numberOfItemsInSection:1], 4);
 }
 
-- (void)test_whenCollectionViewNotInWindow_andDiffSkippingFlagSetNO_diffHappens
-{
+- (void)test_whenCollectionViewNotInWindow_andDiffSkippingFlagSetNO_diffHappens {
  self.updater.skipsDiffingWhenOffscreen = NO;
  [self.collectionView removeFromSuperview];
 
@@ -481,8 +480,7 @@ - (void)test_whenCollectionViewNotInWindow_andDiffSkippingFlagSetNO_diffHappens
  [mockDelegate verify];
 }
 
-- (void)test_whenCollectionViewNotInWindow_andDiffSkippingFlagDefaultYES_diffDoesNotHappen
-{
+- (void)test_whenCollectionViewNotInWindow_andDiffSkippingFlagDefaultYES_diffDoesNotHappen {
  [self.collectionView removeFromSuperview];
 
  id mockDelegate = [OCMockObject niceMockForProtocol:@protocol(IGListAdapterUpdaterDelegate)];