Skip to content

Commit

Permalink
Add tvOS support. Close #118
Browse files Browse the repository at this point in the history
Summary:
Closes #118.

- Add tvOS framework + test targets
- Add shared scheme `IGListKit-tvOS`
- Update `Podfile` and `.podspec`
- Update `.travis.yml`
- Update `CHANGELOG`
- Update `README`
- Run `pod install` and check-in updates

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes #137

Differential Revision: D4101583

Pulled By: rnystrom

fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
  • Loading branch information
jessesquires authored and Facebook Github Bot committed Oct 29, 2016
1 parent e207ae5 commit e4a4719
Show file tree
Hide file tree
Showing 36 changed files with 2,216 additions and 488 deletions.
12 changes: 9 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@ gemfile: Gemfile
cache:
- bundler
- cocoapods

env:
global:
- LANG=en_US.UTF-8

- WORKSPACE="IGListKit.xcworkspace"

- IOS_SCHEME="IGListKit"
- TVOS_SCHEME="IGListKit-tvOS"

- IOS_SDK=iphonesimulator10.0
- TVOS_SDK=appletvsimulator10.0

matrix:
- DESTINATION="OS=8.1,name=iPhone 6" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="NO" BUILD_EXAMPLE="YES" POD_LINT="YES"
Expand All @@ -27,6 +30,9 @@ env:

- DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" POD_LINT="NO"

- DESTINATION="OS=9.0,name=Apple TV 1080p" SDK="$TVOS_SDK" SCHEME="$TVOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" POD_LINT="NO"
- DESTINATION="OS=10.0,name=Apple TV 1080p" SDK="$TVOS_SDK" SCHEME="$TVOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" POD_LINT="NO"

script:
- if [ $POD_LINT == "YES" ]; then
bundle exec pod lib lint;
Expand All @@ -45,4 +51,4 @@ script:
fi

after_success:
- cd $TRAVIS_BUILD_DIR && bundle exec slather
- cd $TRAVIS_BUILD_DIR && bundle exec slather
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ This release closes the [2.0.0 milestone](https://github.com/Instagram/IGListKit
### Enhancements

- Added support for cells created from nibs. [Sven Bacia](https://github.com/svenbacia) [(#56)](https://github.com/Instagram/IGListKit/pull/56)
- Added an additional initializer for `IGListSingleSectionController` to be able to support single sections created from nibs. An example can be found [here](Example/IGListKitExamples/ViewControllers/SingleSectionViewController.swift).
- Added an additional initializer for `IGListSingleSectionController` to be able to support single sections created from nibs. An example can be found [here](Example/IGListKitExamples/ViewControllers/SingleSectionViewController.swift).
- Fixed `-[IGListAdapter reloadDataWithCompletion:]` not returning early when `collectionView` or `dataSource` is nil and `completion` is nil. [Ben Asher](https://github.com/benasher44) [(#51)](https://github.com/Instagram/IGListKit/pull/51)
- Added `-isFirstSection` and `-isLastSection` APIs to `IGListSectionController`
- Added support for cells created from storyboard. [Bofei Zhu](https://github.com/zhubofei) [(#92)](https://github.com/Instagram/IGListKit/pull/92)
- Added `tvOS` support. [Jesse Squires](https://github.com/jessesquires) [(#137)](https://github.com/Instagram/IGListKit/pull/137)

1.0.0
-----
Expand Down
4 changes: 3 additions & 1 deletion IGListKit.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ Pod::Spec.new do |s|
s.private_header_files = 'Source/Internal/*.h'

s.requires_arc = true
s.platform = :ios, '8.0'

s.ios.deployment_target = '8.0'
s.tvos.deployment_target = '9.0'

s.frameworks = 'UIKit'
s.library = 'c++'
Expand Down
472 changes: 457 additions & 15 deletions IGListKit.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

99 changes: 99 additions & 0 deletions IGListKit.xcodeproj/xcshareddata/xcschemes/IGListKit-tvOS.xcscheme
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0810"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "885FE1D31DC51A0D009CE2B4"
BuildableName = "IGListKit.framework"
BlueprintName = "IGListKit-tvOS"
ReferencedContainer = "container:IGListKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "885FE1DB1DC51A0D009CE2B4"
BuildableName = "IGListKit-tvOSTests.xctest"
BlueprintName = "IGListKit-tvOSTests"
ReferencedContainer = "container:IGListKit.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "885FE1D31DC51A0D009CE2B4"
BuildableName = "IGListKit.framework"
BlueprintName = "IGListKit-tvOS"
ReferencedContainer = "container:IGListKit.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "885FE1D31DC51A0D009CE2B4"
BuildableName = "IGListKit.framework"
BlueprintName = "IGListKit-tvOS"
ReferencedContainer = "container:IGListKit.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "885FE1D31DC51A0D009CE2B4"
BuildableName = "IGListKit.framework"
BlueprintName = "IGListKit-tvOS"
ReferencedContainer = "container:IGListKit.xcodeproj">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
5 changes: 4 additions & 1 deletion Podfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
source 'https://github.com/CocoaPods/Specs.git'
use_frameworks!
platform :ios, '8.0'

workspace 'IGListKit'

target 'IGListKitTests' do
pod 'OCMock', '~> 3.0'
end

target 'IGListKit-tvOSTests' do
pod 'OCMock', '~> 3.0'
end
4 changes: 2 additions & 2 deletions Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ DEPENDENCIES:
SPEC CHECKSUMS:
OCMock: f3f61e6eaa16038c30caa5798c5e49d3307b6f22

PODFILE CHECKSUM: 0747417a7e8e5f7b8c94af3ee51c896efedab170
PODFILE CHECKSUM: 1b17ed45981d46d2fb3fb4b7b1caf09333626898

COCOAPODS: 1.1.0.rc.3
COCOAPODS: 1.1.1
4 changes: 2 additions & 2 deletions Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e4a4719

Please sign in to comment.