-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-selection #184
Comments
I obviously don't have the proper context into why we don't want to use |
@cdoncarroll It's not a bad API, but I whipped up a sample project illustrating a few of these ideas: UICollectionViewDeselection.zip Where you have Then there's Also you have to override Putting this all together, we end up reimplementing the selection API and introduce some weird In the end we do a lot of complicated things and possibly introduce some weird behavior all to save clients tracking state themselves, which shouldn't be hard. |
@rnystrom so what's the right way of managing selected cells (setting a state, getting a list of selected) for IGListCollectionView? |
@kronik I'll make sure to get an example up, but for now probably manually tracking selection in the section controllers. The trickier part is then getting a list of selected stuff. There are two options that I've seen work:
I'd probably go w/ the first option. However @cdoncarroll and I were chatting a lot last week about this and we might try to find a way to bake support into IGListKit, but to fully support selection it'll be a bigger change, so nothing concrete planned. |
@rnystrom Got it. Thanks. |
Summary: Adding support for a cell deselection API. Trying to make some headway to move and drag+drop support, but also want better stock `UICollectionView` API support. Will also assist eventual `UITableView` support. - Added overridable API to `IGListSectionController` - Support for stacked SC - Breaking, required protocol for binding SC Assists #524 and #184 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes #853 Reviewed By: jeremycohen Differential Revision: D5425414 Pulled By: rnystrom fbshipit-source-id: 0b25c125b1f171979a15c3095095fc18b4108be6
Been asked this quiet a lot internally. It's easy to do but different than traditional
UICollectionView
. The whole "deselect" API is not what we want to be using for this.The text was updated successfully, but these errors were encountered: