Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGListAdapter‘s scrollViewDelegate #842

Closed
threeknife opened this issue Jul 1, 2017 · 1 comment
Closed

IGListAdapter‘s scrollViewDelegate #842

threeknife opened this issue Jul 1, 2017 · 1 comment
Labels
question

Comments

@threeknife
Copy link

only 3 delegate was implemented.

  • (void)scrollViewDidScroll:(UIScrollView *)scrollView
  • (void)scrollViewWillBeginDragging:(UIScrollView *)scrollView
  • (void)scrollViewDidEndDragging:(UIScrollView *)scrollView willDecelerate:(BOOL)decelerate

and other delegate like

  • (void)scrollViewWillBeginDecelerating:(UIScrollView *)scrollView
  • (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView
    was not implemented.

I want to know Why?
@rnystrom
Copy link
Contributor

rnystrom commented Jul 3, 2017

@threeknife simply necessity. Within Instagram these are the only methods that we have been using. It'll be simple to add these, but mostly leaning on the open source community to show a need, request, and fix + test. Tbh since we do not allow @optional in our protocols, this would have just added more unused boilerplate.

Def not opposed to adding if there's a real need in the future.

@rnystrom rnystrom closed this as completed Jul 3, 2017
@plarson plarson mentioned this issue Aug 15, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue Aug 23, 2017
@plarson @facebook-github-bot
IGListAdapter support for scrollViewDidEndDecelerating
1717b2c 
Summary:
References #842

We use -[UIScrollViewDelegate scrollViewDidEndDecelerating:] delegate callback in the app we are building to hide/show elements when motion has ended.
Closes #899

Differential Revision: D5689239

Pulled By: rnystrom

fbshipit-source-id: ea17fe94ccacc5e4f0a9e085e61f8f77cfcea3b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rnystrom @threeknife