Add new iOS 11 api adjustedContentInset support

[yiplee]

adopt adjustedContentInset instead of contentInset on iOS 11

Checklist

• All tests pass. Demo project builds and runs.
• I added tests, an experiment, or detailed why my change isn't tested.
• I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
• I have reviewed the contributing guide

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

@yiplee has updated the pull request.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[rnystrom]

Awesome! Would love a change log entry and even a unit test for this.

_{Sent with GitHawk}

[facebook-github-bot]

@yiplee has updated the pull request. View: changes

[facebook-github-bot]

@yiplee has updated the pull request. View: changes

[facebook-github-bot]

@yiplee has updated the pull request. View: changes

[facebook-github-bot]

@yiplee has updated the pull request. View: changes

[yiplee]

Change log entry and unit test added :)

[rnystrom]

Last thing! Can you run the Examples/pod_setup.sh script to make sure the examples projects have your new file included?

[yiplee]

Yes, the new files have been included by pod. @rnystrom

[rnystrom]

@yiplee are the examples building for you?

[facebook-github-bot]

@yiplee has updated the pull request. View: changes

[facebook-github-bot]

@yiplee has updated the pull request.

[iglistkit-bot]

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

[rnystrom]

@yiplee last change request from me!

I thought about this more over the holidays. There's a chance that this will change behavior and introduce bugs when people explicitly want the contentInset and not the adjusted inset.

Could we instead provide a new API on the context, something like:

@protocol IGListCollectionContext
// ...
- (UIEdgeInsets)adjustedContainerInset;
// ...
@end

That way people can choose which they need w/out breaking any existing solutions?

[yiplee]

@rnystrom I agree with you. But the bug will remain exist if people forget to replace containerInset by adjustedContainerInset in their codes. And in my opinion, when people call context's containerInset, they expect context to return the real content inset applied to collectionView.

[rnystrom]

@yiplee though even more about this, I think the only way to go is with a separate API. I found a few places that will break in Instagram if we make this change, so that’s a blocker.

Would you be ok making this a separate API? Thanks!!

_{Sent with GitHawk}

[yiplee]

@rnystrom It's OK. I will update the PR right now. 😄

[facebook-github-bot]

@yiplee has updated the pull request. View: changes

[facebook-github-bot]

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@yiplee has updated the pull request. View: changes, changes since last import

[facebook-github-bot]

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.