Minimum fixes for Xcode 9.3 build errors

[ikesyo]

Changes in this pull request

Issue fixed: #1141

This is a set of minimum fixes for Xcode 9.3 rather than #1142. Much smaller diffs 😃

The changes here were done by Xcode's FixIt. See also https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html#//apple_ref/doc/uid/TP40004265-SW5.

Platform Dependencies

OS X uses several data types—NSInteger, NSUInteger,CGFloat, and CFIndex—to provide a consistent means of representing values in 32- and 64-bit environments. In a 32-bit environment, NSInteger and NSUInteger are defined as int and unsigned int, respectively. In 64-bit environments, NSInteger and NSUInteger are defined as long and unsigned long, respectively. To avoid the need to use different printf-style type specifiers depending on the platform, you can use the specifiers shown in Table 3. Note that in some cases you may have to cast the value.

Checklist

• All tests pass. Demo project builds and runs.
• I added tests, an experiment, or detailed why my change isn't tested.
• I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
• I have reviewed the contributing guide

[facebook-github-bot]

@ikesyo has updated the pull request. View: changes

[facebook-github-bot]

@ikesyo has updated the pull request. View: changes

[iglistkit-bot]

	1 Warning
⚠️	All pull requests should have a milestone attached, unless marked #trivial.

Generated by 🚫 Danger

[ikesyo]

@rnystrom @jessesquires Could you please review this?

[facebook-github-bot]

@ikesyo has updated the pull request.

[ikesyo]

I'm not sure why there are some SwiftLint violations from Examples in this PR: https://travis-ci.org/Instagram/IGListKit/jobs/361956020 but those are not seen in master: https://travis-ci.org/Instagram/IGListKit/jobs/361911790

[facebook-github-bot]

@ikesyo has updated the pull request. View: changes

[ikesyo]

#1143 (comment)

Updated .swiftlint.yml to exclude the occurences:

• url
• to
• obj
• str
• set

[facebook-github-bot]

@ikesyo has updated the pull request. View: changes

[facebook-github-bot]

@ikesyo has updated the pull request. View: changes

[ethanjdiamond]

Hi IG team!

Are you planning on merging this in and releasing soon? It's blocking my team's upgrade to Xcode 9.3.

[iostriz]

Hi IGlisters,
this is a real showstopper for our team also.
Please?

[rnystrom]

Our internal CI just moved to 9.3 over the weekend which means we can merge, that was the only thing holding us back. I’ll land this today!

_{Sent with GitHawk}

[facebook-github-bot]

@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[ethanjdiamond]

Thanks for the quick work @rnystrom! Is the team going to put out a release soon to grab this change from, or should we temporarily tie it to this commit hash?

[rnystrom]

@ethanjdiamond we’re stabilizing a couple recent merges and want to hold a fresh release til it’s totally stable. Feel free to just use the master branch for the time being (it’s what we use in Instagram).

_{Sent with GitHawk}

[SebastianBoldt]

@rnystrom
Is there already a concrete date when the new version will be released? We would like to upgrade our build server to the new Xcode version, but the last IGListKit version does not work with Swift 4.1.

[rnystrom]

@SebastianBoldt nothing concrete but its moving right now (see #1150 and #1151). Blocked on CI for #1152 that I'm trying to figure out. Once that's moving it's just a matter of genning docs and publishing. Shouldn't be more than a couple days!