Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a grid layout for IGList #225

Closed
wants to merge 1 commit into from

Conversation

zhubofei
Copy link

@zhubofei zhubofei commented Nov 19, 2016

Rebase from #140:

Create a flow layout for IGList that does not newline sections. Closes #3

  • Minimum inter-item spacing
  • Minimum line spacing
  • Constant item size with constant layout time
  • Update layout on insert/delete/move
  • Unit Test

@zhubofei
Copy link
Author

Still no coverall 😂

@jessesquires
Copy link
Contributor

Thanks @zhubofei ! 💯

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jessesquires
Copy link
Contributor

@rnystrom -- Are we targeting this for the 2.0 release?

@rnystrom
Copy link
Contributor

@jessesquires ya I think so, sound good? Importing today

@jessesquires
Copy link
Contributor

@rnystrom - don't forget to update the CHANGELOG 😄.

Maybe we could merge #234 first though? 😊

@rnystrom
Copy link
Contributor

Updated changelog, fixed some compiler errors from our strict build settings, and created a local var for self.collectionView in the attributes-for-rect method. Landing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants