Fix stacked section controller OOB when cell ends display #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,8 @@ This release closes the [2.1.0 milestone](https://github.com/Instagram/IGListKit | |||
|
|
|||
| - Prevent adapter data source from deallocating after queueing an update. [Ryan Nystrom](https://github.com/rnystrom) (tbd) | |||
|
|
|||
| - Fix OOB bug when child section controllers in a stack remove cells. [Ryan Nystrom](https://github.com/rnystrom) [(#358)](https://github.com/Instagram/IGListKit/pull/358) | |||
There was a problem hiding this comment.
spell out out-of-bounds 😄
|
@rnystrom updated the pull request - view changes |
|
@rnystrom - oh i forgot, we can edit files inline on the GH web UI. pretty sweet. fixed my own nits. 😄 we should probably do this with contributors from now on instead of commenting. |
|
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@jessesquires that is AWESOME. Hell yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Fixes bug reported internally. When items are removed dynamically the stack internal store will attempt to access data that has already been removed. Instead use assoc objects.
We did change
IGListAdapterto use a map instead of assoc objects. That could be a good cleanup.cc @cdoncarroll
Pull request checklist