Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical UICollectionViewLayout supporting inline sections (take 2) #484

Closed
wants to merge 9 commits into from

Conversation

rnystrom
Copy link
Contributor

Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it.

This is still a WIP as I add more tests, but I'd love as much feedback as possible.

Aside from the glob of header documentation, this has the following features:

  • Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row.
  • Sections can have their own insets, line spacing, and interitem spacing.
  • Sticky header support! When you use headers, it will always newline the section.
  • Maximum width with a border decoration view
    • Use this to pinch in your content on larger devices

Followup to #423

TODO

  • Move decoration view support to delegate removed
  • Unit test changing top y sticky inset
  • Update initWithCoder: to use sensible defaults
  • Test initWithCoder: throws
  • Test when remaining cells outside of visible bounds
  • Move decorationBorderViewOfKind: internal? C function? (or add unit tests) removed
  • Unit test changing bounds size

Copied from #450

@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants