Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell (un)highlight APIs #933

Closed
wants to merge 4 commits into from
Closed

Add cell (un)highlight APIs #933

wants to merge 4 commits into from

Conversation

delannoyk
Copy link
Contributor

This implements the collectionView:didHighlightItemAtIndexPath: and collectionView:didUnhighlightItemAtIndexPath: UICollectionViewDelegate APIs and forward the calls to the appropriate IGListSectionController.
For the most part, it's doing the same thing as the collectionView:didDeselectItemAtIndexPath: calls and tests are also based on that feature.

Changes in this pull request

  • Implements collectionView:didHighlightItemAtIndexPath: and collectionView:didUnhighlightItemAtIndexPath: in IGListAdapter
  • Catch those selectors in IGListAdapterProxy
  • Adds didHighlightItemAtIndex: and didUnhighlightItemAtIndex: methods to IGListSectionController and friends (supports IGListBindingSectionController via its delegate and IGListStackedSectionController)
  • Tests for changes

Issue fixed: I didn't open one, so none I guess.

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

@delannoyk updated the pull request - view changes

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rnystrom rnystrom self-requested a review September 14, 2017 00:46
@rnystrom rnystrom added this to the 3.2.0 milestone Sep 14, 2017
@rnystrom
Copy link
Contributor

This is so good omg. Will set aside some time to properly review everything. Make sure you sign the CLA, that's required before we can import anything.

@facebook-github-bot
Copy link
Contributor

@delannoyk has updated the pull request. View: changes

@facebook-github-bot
Copy link
Contributor

@delannoyk has updated the pull request. View: changes

@facebook-github-bot
Copy link
Contributor

@delannoyk has updated the pull request. View: changes

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@rnystrom rnystrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants