-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cell (un)highlight APIs #933
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@delannoyk updated the pull request - view changes |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This is so good omg. Will set aside some time to properly review everything. Make sure you sign the CLA, that's required before we can import anything. |
@delannoyk has updated the pull request. View: changes |
@delannoyk has updated the pull request. View: changes |
@delannoyk has updated the pull request. View: changes |
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
This implements the
collectionView:didHighlightItemAtIndexPath:
andcollectionView:didUnhighlightItemAtIndexPath:
UICollectionViewDelegate
APIs and forward the calls to the appropriateIGListSectionController
.For the most part, it's doing the same thing as the
collectionView:didDeselectItemAtIndexPath:
calls and tests are also based on that feature.Changes in this pull request
collectionView:didHighlightItemAtIndexPath:
andcollectionView:didUnhighlightItemAtIndexPath:
in IGListAdapterIGListAdapterProxy
didHighlightItemAtIndex:
anddidUnhighlightItemAtIndex:
methods to IGListSectionController and friends (supportsIGListBindingSectionController
via its delegate andIGListStackedSectionController
)Issue fixed: I didn't open one, so none I guess.
Checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.