scope_provider: Simplify parent resolution #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 255 255
Lines 26366 26366
=======================================
Hits 24004 24004
Misses 2362 2362
☔ View full report in Codecov by Sentry. |
This PR introduces `Scope._next_visible_parent` which deduplicates much of the logic between `_contains_in_self_or_parent`, `_find_assignment_target_parent`, and `_getitem_from_self_or_parent`. This will be helpful when implementing scope resolution for the future `AnnotationScope`. There should be no functionality change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope_provider: Simplify parent resolution
This PR introduces
Scope._next_visible_parentwhich deduplicates much of the logic between_contains_in_self_or_parent,_find_assignment_target_parent, and_getitem_from_self_or_parent.This will be helpful when implementing scope resolution for the future
AnnotationScope.There should be no functionality change.
Stack created with Sapling. Best reviewed with ReviewStack.