fix is_annotation for types used in classdef base and assign value #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zsol
requested changes
Oct 21, 2020
libcst/metadata/scope_provider.py
Outdated
| @@ -647,6 +647,7 @@ def __init__(self, provider: "ScopeProvider") -> None: | |||
| Union[cst.Call, cst.Annotation, cst.Subscript] | |||
| ] = set() | |||
| self.__in_ignored_subscript: Set[cst.Subscript] = set() | |||
| self.__ignore_annotation: bool = False | |||
There was a problem hiding this comment.
This should probably be a stack or a counter instead of a simple bool to keep track of nesting. Let's add a nested test case while we're at it.
jimmylai
reviewed
Oct 21, 2020
libcst/metadata/scope_provider.py
Outdated
Comment on lines
725
to
730
| def visit_Assign_value(self, node: cst.Assign) -> None: | ||
| self.__ignore_annotation += 1 | ||
|
|
||
| def leave_Assign_value(self, node: cst.Assign) -> None: | ||
| self.__ignore_annotation -= 1 | ||
|
|
There was a problem hiding this comment.
Handle Assign differently doesn't seem right.
We should only consider the is_annotation for access in Annotation node (__in_annotation already takes case that).
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 94.11% 94.11% -0.01%
==========================================
Files 231 231
Lines 22427 22449 +22
==========================================
+ Hits 21108 21128 +20
- Misses 1319 1321 +2
Continue to review full report at Codecov.
|
zsol
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix is_annotation for types used in classdef base and assign value
discussion
Test Plan
tox -e py37
tox -e autofix