Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle string type references in cast() #418

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Handle string type references in cast() #418

merged 2 commits into from
Nov 17, 2020

Conversation

Kronuz
Copy link
Contributor

@Kronuz Kronuz commented Nov 12, 2020

Summary

Handle cast("Type", object) so Type is properly referenced in the scope.

Test Plan

Run tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #418 (e30a8c4) into master (7478d73) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         232      232           
  Lines       22437    22460   +23     
=======================================
+ Hits        21159    21182   +23     
  Misses       1278     1278           
Impacted Files Coverage Δ
libcst/metadata/scope_provider.py 96.73% <100.00%> (+0.03%) ⬆️
libcst/metadata/tests/test_scope_provider.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7478d73...e30a8c4. Read the comment docs.

libcst/metadata/scope_provider.py Outdated Show resolved Hide resolved
Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
@zsol zsol merged commit 1100951 into master Nov 17, 2020
@zsol zsol deleted the Kronuz-cast branch November 17, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants